Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsequent of PR #22359 #22371

Closed
wants to merge 3 commits into from
Closed

Conversation

bung87
Copy link
Collaborator

@bung87 bung87 commented Aug 3, 2023

if my understanding right, this fix chronos fails by my previous PR.

@bung87
Copy link
Collaborator Author

bung87 commented Aug 3, 2023

fails by timezones/fetchjsontimezones /home/runner/work/Nim/Nim/lib/pure/httpclient.nim(1288) downloadFile Error: unhandled exception: 503 Service Unavailable [HttpRequestError]

created issue here: GULPF/timezones#11

@bung87 bung87 closed this Aug 3, 2023
@bung87 bung87 reopened this Aug 3, 2023
Copy link
Member

@ringabout ringabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to include #22367 as a part of this PR so that we will know whether it fixes the real problem.

@bung87
Copy link
Collaborator Author

bung87 commented Aug 3, 2023

I tested it locally, that PR is questionable to be accepted, see araq's comment

@ringabout
Copy link
Member

ringabout commented Aug 3, 2023

That is not what I meant. You need to verify whether #22359 is the cause of chronos failures. As a part of verification, you need to show the result of testing chronos with the option -d:release -d:useSysAssert -d:useGcAssert --mm:refc. Whatever, are you sure that the chronos failure is caused by your PR?

@bung87
Copy link
Collaborator Author

bung87 commented Aug 3, 2023

I verified locally by change code to previous and run same command agains to chronos, and I tested my PR locally, otherwise I wouldn't create this PR, if as you said I even don't know the cause. and I also checked chronos CI there's only one reversion between success and fails, that's my previous PR.

@ringabout
Copy link
Member

ringabout commented Aug 3, 2023

So merge #22374 into your PR, the old PR breaks chronis when using refc, which is not related with sysassert or whatsoever.

@bung87 bung87 closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants