-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subsequent of PR #22359 #22371
subsequent of PR #22359 #22371
Conversation
fails by created issue here: GULPF/timezones#11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to include #22367 as a part of this PR so that we will know whether it fixes the real problem.
I tested it locally, that PR is questionable to be accepted, see araq's comment |
That is not what I meant. You need to verify whether #22359 is the cause of chronos failures. As a part of verification, you need to show the result of testing chronos with the option |
I verified locally by change code to previous and run same command agains to chronos, and I tested my PR locally, otherwise I wouldn't create this PR, if as you said I even don't know the cause. and I also checked chronos CI there's only one reversion between success and fails, that's my previous PR. |
So merge #22374 into your PR, the old PR breaks chronis when using refc, which is not related with sysassert or whatsoever. |
if my understanding right, this fix chronos fails by my previous PR.