fix #22218 copy generated for non-copyable type #22447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Aug 12, 2023
| @@ -1113,6 +1125,7 @@ proc moveOrCopy(dest, ri: PNode; c: var Con; s: var Scope, flags: set[MoveOrCopy | |||
| # We know the result will be a stmt so we use that fact to optimize | |||
| handleNestedTempl(ri, process, willProduceStmt = true) | |||
| else: | |||
| c.checkOpError(ri, attachedAsgn) | |||
There was a problem hiding this comment.
Instead it should not have been computed to be a cursor. Also, only in this one case we now get a more informative error message. Sorry, but you need to stop hacking things into random places just to make tests pass but instead need to understand the overall architecture of the compiler and look into existing logic and why it fails.
There was a problem hiding this comment.
for whatever reason it will fails, the user code want do an assignment, but have already defined =copy as error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted
assertfails when I run testament locally.