Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #22469; generates nimTestErrorFlag for top level statements #22472

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fixes #22469; generates nimTestErrorFlag for top level statements #22472

merged 2 commits into from
Aug 14, 2023

Conversation

ringabout
Copy link
Member

fixes #22469

@Araq Araq added the merge_when_passes_CI mergeable once green label Aug 14, 2023
@ringabout
Copy link
Member Author

timezone failures are unrelated:

Error: unhandled exception: 503 Service Unavailable [HttpRequestError]

@Araq Araq merged commit 09d0fda into devel Aug 14, 2023
19 checks passed
@Araq Araq deleted the pr_types_refactor branch August 14, 2023 11:08
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 09d0fda

Hint: mm: orc; opt: speed; options: -d:release
169172 lines; 12.297s; 611.527MiB peakmem

narimiran pushed a commit that referenced this pull request Apr 17, 2024
@ringabout @narimiran
fixes #22469; generates nimTestErrorFlag for top level statements (#2…
646c4d1 
…2472)

fixes #22469; generates `nimTestErrorFlag` for top level statements

(cherry picked from commit 09d0fda)
narimiran pushed a commit that referenced this pull request Apr 17, 2024
@ringabout @narimiran
fixes #22469; generates nimTestErrorFlag for top level statements (#2…
2a4755d 
…2472)

fixes #22469; generates `nimTestErrorFlag` for top level statements

(cherry picked from commit 09d0fda)
@ringabout ringabout mentioned this pull request Sep 5, 2024
Merged
Araq pushed a commit that referenced this pull request Sep 5, 2024
@ringabout
fixes #23897; Useless empty C files with arc/orc (#24064)
9ff15da 
fixes #23897

follow up #21288
follow up #22472

Since #22472 triggers `nimTestErrorFlag` in every module that isn't
empty, this PR removes unnecessary logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exceptions in top level statements of submodule not being reported/handled
2 participants
@ringabout @Araq