fix subscript in generics, typeof, lent with bracket
#24067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
changed the title
lent with bracketlent with bracket
|
Please rebase. |
metagn
force-pushed
the
subscript-tyfromexpr
branch
from
e9e1f95 to
c94f1ad
Compare
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15959
Another followup of #22029 and #24005, subscript expressions now recognize when their parameters are generic types, then generating tyFromExpr.
typeofalso now properly setstfNonConstExprto make it usable in proc signatures.lentwith brackets likelent[T]is also now allowed.