disallow implicit return if result
is used, don't use void context
#24406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16855
Assigning to the
result
variable makes the assignment expression have a type oftyped
, which causes any subsequent expressions in the same statement list as the assignment to require a void type, so that theresult
variable cannot be overriden by implicit returns. This has multiple issues:result
, not just the proc body.foo(result)
can fool this and still allow an implicit return.To fix this, we track if the
result
symbol is used, then error if an implicit return is attempted. An exception is granted toreturn
statements which generate an assignment to theresult
variable: if the result variable was not used before, it will not count as used after.