Network: enable DHT server mode only while consensus is established #3038
+112
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eligioo
reviewed
Nov 12, 2024
| @@ -534,6 +535,10 @@ impl Network for MockNetwork { | |||
| // TODO implement | |||
| } | |||
|
|
|||
| async fn dht_set_mode(&self, _mode: DhtMode) { | |||
| // TODO implement | |||
There was a problem hiding this comment.
Set an unimplemented!() here? Same for validate_message. Otherwise the caller has no idea this still needs an actual impl
| @@ -1041,6 +1052,27 @@ fn perform_action(action: NetworkAction, swarm: &mut NimiqSwarm, state: &mut Tas | |||
| let result = swarm.dial(dial_opts).map_err(Into::into); | |||
| output.send(result).ok(); | |||
| } | |||
| NetworkAction::DhtSetMode { mode } => { | |||
| #[cfg(feature = "kad")] | |||
There was a problem hiding this comment.
Feature annotations support { } to encapsulate a block of code:
#[cfg(feature = "kad")]
{
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3014, we can only properly verify DHT records once we have the staking contract. Therefore, this PR defers the switch to DHT server mode to when consensus is established. The DHT switches back to client mode when consensus is lost.