Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize genesis block with cashed hash #3133

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Initialize genesis block with cashed hash #3133

merged 1 commit into from
Nov 23, 2024

Conversation

fiaxh
Copy link
Contributor

@fiaxh fiaxh commented Nov 22, 2024 •
edited by sisou
Loading

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

hrxi
hrxi reviewed Nov 22, 2024
View reviewed changes
genesis/src/networks.rs Outdated Show resolved Hide resolved
jsdanielh
jsdanielh approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sisou
sisou approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@sisou sisou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in WASM, works!

@sisou sisou linked an issue Nov 22, 2024 that may be closed by this pull request
Investigate ways to reduce web-client WASM size #3108
Open
@sisou sisou removed a link to an issue Nov 22, 2024
Investigate ways to reduce web-client WASM size #3108
Open
paberr
paberr approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@paberr paberr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsdanielh jsdanielh merged commit c276299 into albatross Nov 23, 2024
5 of 7 checks passed
@jsdanielh jsdanielh deleted the fiaxh/cache_genesis_hash branch November 23, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrxi hrxi hrxi left review comments

@nibhar nibhar nibhar approved these changes

@paberr paberr paberr approved these changes

@jsdanielh jsdanielh jsdanielh approved these changes

@sisou sisou sisou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fiaxh @sisou @jsdanielh @paberr @hrxi @nibhar