Allow the user to define the domTarget, which allows support for shadowDom and more

[exetico]

In the current state, users can't use shadowRoms with this util. Take a look at: #129, #210 and #168

I've added support for domTarget, which can be defined as an option. Documentation has been updated, too.

[exetico]

Kindly take a look at this minimal change, allowing us to use the solution in a shadowDom, @nimiq & @danimoh. Thanks 😃 .

[exetico]

How's going team? I'd like to see this merged :) Thank you for a awesome library.

[jesseditson]

Just a quick nit - I've moved to your branch and using shadowRoot as domTarget directly fails in typescript (although it's valid js), because the type of shadowRoot is ShadowRoot, and domTarget is typed as HTMLDivElement.

I was already embedding in a div so I could fix by grabbing the container:

const domTarget = video.parentElement as HTMLDivElement;
if (!domTarget) {
  throw new Error("Failed to find scan-area");
}

but the type should probably Element or something a bit less specific for cases where folks aren't already embedding in a div. Also the docs probably shouldn't use shadowRoot directly.

Thanks for this patch, I was about to fix this myself so it saved me a step! I'd love to see this land, even as-is.

[exetico]

@jesseditson Feel free to make a PR to my branch, which can be merged into the branch for the PR to the main branch.

[exetico]

@jesseditson Did you find some time, to implement it? You're welcome to add the PR here:

https://github.com/exetico/qr-scanner

but the type should probably Element or something a bit less specific for cases where folks aren't already embedding in a div. Also the docs probably shouldn't use shadowRoot directly.

I'm using TS in one project, so I'm not that into what's "does and donts", so I think you're more capable on adding the missing TS logics.

I'd like to have it as part of my PR, as I expect the change for the nimiq team merging it, are a bit higher. I've asked on Discord and more, but no-one replies...

[exetico]

@sisou What do you think ? :-)

[exetico]

Hi @jesseditson. Do you still use the qr-scanner lib? I've added the required changes to the branch. Else, I'd like a MCVE so I can double-check myself. I don't have a TypeScript project with shadowDom's right now, so I'd like a input on that part.

I'd hope to see this merged by the nimiq team. But I'm not sure who I should try and contact at this point. Maybe @onmax or @sisou ?