feat: support detection of node/npm apps #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrox
force-pushed
the
support-nodejs
branch
from
df86a29 to
17a6f0e
Compare
This adds some more logic to also detect node-based frontend apps. The web-servers buildpack already takes care of running `npm build` but in case that happens we need to serve the resulting artifacts from `/workspace/build`. We do that by leveraging the libnodejs package to detect if we have a nodejs app and then we set the build directory as the webroot.
ctrox
force-pushed
the
support-nodejs
branch
from
17a6f0e to
a57dde8
Compare
gajicdev
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more logic to also detect node-based frontend apps. The web-servers buildpack already takes care of running
npm buildbut in case that happens we need to serve the resulting artifacts from/workspace/build. We do that by leveraging the libnodejs package to detect if we have a nodejs app and then we set the build directory as the webroot.