make the token and control urls configurable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gajicdev
force-pushed
the
configure-urls
branch
from
c7b0341
to
7f9120a
Compare
ctrox
reviewed
Oct 29, 2024
gajicdev
force-pushed
the
configure-urls
branch
2 times, most recently
from
bd4cd8d
to
adc5256
Compare
gajicdev
force-pushed
the
configure-urls
branch
from
adc5256
to
d82e7f9
Compare
ctrox
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds the changes for making the token and control url configurable.
The second is to make the pr mergable, since the vm test runs only in the tailscale repo: https://github.com/ninech/tailscale/blob/main/.github/workflows/test.yml#L202
The third commit is adding a workflow to build the operator when tagging the repo. Currently tailscale builds it internally and syncs it publicly.