Skip to content

Remove unused constructor parameters #147

Remove unused constructor parameters

Remove unused constructor parameters #147

Re-run triggered February 5, 2024 13:41
Status Success
Total duration 3m 32s
Artifacts 1

maven.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 warnings
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build: src/main/java/pl/net/was/trino/git/GitConnector.java#L53
Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: GitTransactionHandle.
build: src/main/java/pl/net/was/trino/git/GitSplitManager.java#L112
Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
build: src/test/java/pl/net/was/trino/git/TestGitClient.java#L68
Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
build: src/test/java/pl/net/was/trino/git/TestGitClient.java#L78
Implicit use of the platform default charset, which can result in differing behaviour between JVM executions or incorrect behavior if the encoding of the data source doesn't match expectations.

Artifacts

Produced during runtime
Name Size
test report build Expired
246 KB