Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid HashMap concurrent access issue in dependency-version-check-work executor service #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid HashMap concurrent access issue in dependency-version-check-work executor service #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...n/java/com/ning/maven/plugins/dependencyversionscheck/AbstractDependencyVersionsMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.Set;
import java.util.SortedMap;
import java.util.TreeMap;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Executors;
import java.util.concurrent.locks.Lock;
Expand Down Expand Up @@ -257,13 +258,13 @@ public abstract class AbstractDependencyVersionsMojo extends AbstractMojo
protected final Logger LOG = LoggerFactory.getLogger(this.getClass());

/** ArtifactName to VersionStrategy. Filled in loadResolvers(). */
protected final Map resolverMap = new HashMap();
protected final Map resolverMap = new ConcurrentHashMap();

/** Artifact pattern to VersionStrategy. Filled in loadResolvers(). */
protected final Map resolverPatternMap = new HashMap();
protected final Map resolverPatternMap = new ConcurrentHashMap();

/** Qualified artifact name to artifact. */
protected final Map resolvedDependenciesByName = new HashMap();
protected final Map resolvedDependenciesByName = new ConcurrentHashMap();

protected Strategy defaultStrategyType;

Expand Down