Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid based Emoji Picker #159

Draft
wants to merge 10 commits into
base: stable
Choose a base branch
from
Draft

Grid based Emoji Picker #159

wants to merge 10 commits into from

Conversation

kiliankoe
Copy link
Member

@kiliankoe kiliankoe commented Jun 27, 2020

This uses the new LazyVGrid. It works, but it's far from ideal, especially regarding performance. Any ideas on how to improve it would be much appreciated. The category picker was a try at improving things, but scrolling is still terrible and switching categories also takes seconds in some cases.

  • Frequently used category (could @AppState be used for that?)
  • design improvements, especially regarding the search bar
  • Think about a separate "quick-reaction" view (see Signal, Slack or Riot iOS)
  • Localizations
  • Think about supporting custom emotes
  • Any way of not having the sheet cover the entire screen?

See #63

@kiliankoe
Copy link
Member Author

kiliankoe commented Jun 28, 2020

I played around with the design a bit, this is what it now looks like. A lot like Slack.

I'm using SF Symbols for the category icons now, but there doesn't appear to be anything related to food at all, therefore the thermometer 🙄

Also this drops the dependency on Smile and uses the json file Smile uses to generate its data directly. That gives a bit more flexibility, but doesn't really improve the performance unfortunately.

@regexident
Copy link
Collaborator

I think for the sake of ergonomics we should stick with the categories used by iOS.

  • People
  • Nature
  • Foods
  • Activities
  • Places
  • Objects
  • Symbols
  • Flags

Otherwise the users will have to do all kind of mental acrobatics to figure where to look for their favorite emoji.

@kiliankoe
Copy link
Member Author

Yeah I wanted to as well and it would be much easier if there were any kind of APIs for working with emoji data. But I also really don't want to curate our own lists of Emoji, that'll be a nightmare to keep up to date on OS updates :/

Base automatically changed from iOS14 to stable July 1, 2020 21:45
@kiliankoe kiliankoe mentioned this pull request Jul 29, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants