-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid based Emoji Picker #159
base: stable
Are you sure you want to change the base?
Conversation
I played around with the design a bit, this is what it now looks like. A lot like Slack. I'm using SF Symbols for the category icons now, but there doesn't appear to be anything related to food at all, therefore the thermometer 🙄 Also this drops the dependency on Smile and uses the json file Smile uses to generate its data directly. That gives a bit more flexibility, but doesn't really improve the performance unfortunately. |
I think for the sake of ergonomics we should stick with the categories used by iOS.
Otherwise the users will have to do all kind of mental acrobatics to figure where to look for their favorite emoji. |
Yeah I wanted to as well and it would be much easier if there were any kind of APIs for working with emoji data. But I also really don't want to curate our own lists of Emoji, that'll be a nightmare to keep up to date on OS updates :/ |
It was easy to miss floating at the bottom
f59cee7
to
cfb5075
Compare
This uses the new
LazyVGrid
. It works, but it's far from ideal, especially regarding performance. Any ideas on how to improve it would be much appreciated. The category picker was a try at improving things, but scrolling is still terrible and switching categories also takes seconds in some cases.@AppState
be used for that?)See #63