Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define volumetric space and resolution in CIFTI outputs #3341

Closed
tsalo opened this issue Aug 6, 2024 · 3 comments
Closed

Explicitly define volumetric space and resolution in CIFTI outputs #3341

tsalo opened this issue Aug 6, 2024 · 3 comments

Comments

@tsalo
Copy link
Collaborator

tsalo commented Aug 6, 2024

What would you like to see added in fMRIPrep?

Given that fsLR only describes the surface space, and the volume space of current CIFTI outputs (i.e., MNI152NLin6Asym) is only implied by convention, I think we should add volspace-MNI152NLin6Asym to fsLR-space CIFTI outputs. The volspace entity was proposed in BEP011 Structural Derivatives.

I also was thinking about the density and resolution entities. Does it make sense to use 91k as shorthand for den-32k + res-2, or should we change that?

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

This stems from #3330.
This will require changes to sMRIPrep, Nibabies, and ASLPrep at minimum.

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 6, 2024

I imagine that, since this would change output filenames, it would require a minor release. Might even need to wait until 25.0.0?

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 21, 2024

I've opened bids-standard/bids-specification#1900 to add volspace to BIDS.

@tsalo
Copy link
Collaborator Author

tsalo commented Sep 20, 2024

I've closed that BIDS PR in favor of using +s (@effigies' idea), so I'm going to close this issue. I can open new issues if relevant changes need to be made to fMRIPrep.

@tsalo tsalo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant