-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add volspace and volcohort entities to IO config file #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"name": "cohort", | ||
"pattern": "[_/\\\\]+cohort-0*(\\d+)", | ||
"dtype": "int" | ||
}, | ||
{ | ||
"name": "volcohort", | ||
"pattern": "[_/\\\\]+volcohort-0*(\\d+)", | ||
"dtype": "int" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never noticed this until now, but why are these 0 padded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe an earlier version of pybids had something like that for run, so it parsed int("1")
instead of int("01")
. I don't think it was necessary or that it is still there.
An alternative proposed by @effigies in bids-standard/bids-specification#1900 involves using |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #891 +/- ##
=======================================
Coverage 71.45% 71.45%
=======================================
Files 87 87
Lines 8400 8400
Branches 990 990
=======================================
Hits 6002 6002
Misses 2390 2390
Partials 8 8 ☔ View full report in Codecov by Sentry. |
I'm committing to just using |
Closes none, but relates to #883, bids-standard/bids-specification#1900, and nipreps/fmriprep#3341.
Changes proposed: