Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add volspace and volcohort entities to IO config file #891

Closed
wants to merge 1 commit into from

Conversation

tsalo
Copy link
Contributor

@tsalo tsalo commented Aug 21, 2024

Closes none, but relates to #883, bids-standard/bids-specification#1900, and nipreps/fmriprep#3341.

Changes proposed:

  • Add volspace and volcohort entities to the IO config file.
  • Allow volspace, volcohort, and resolution in CIFTI filenames.

@tsalo tsalo changed the title Add volspace and volcohort entities to IO config file ENH: Add volspace and volcohort entities to IO config file Aug 21, 2024
@tsalo
Copy link
Contributor Author

tsalo commented Aug 21, 2024

@effigies @mgxd would you mind taking a look at this at some point?

Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 153 to +160
"name": "cohort",
"pattern": "[_/\\\\]+cohort-0*(\\d+)",
"dtype": "int"
},
{
"name": "volcohort",
"pattern": "[_/\\\\]+volcohort-0*(\\d+)",
"dtype": "int"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never noticed this until now, but why are these 0 padded?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe an earlier version of pybids had something like that for run, so it parsed int("1") instead of int("01"). I don't think it was necessary or that it is still there.

@tsalo
Copy link
Contributor Author

tsalo commented Aug 21, 2024

An alternative proposed by @effigies in bids-standard/bids-specification#1900 involves using + in the space entity instead of a new entity, so that's a viable alternative.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.45%. Comparing base (1f9a0cf) to head (5ee5f1d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files          87       87           
  Lines        8400     8400           
  Branches      990      990           
=======================================
  Hits         6002     6002           
  Misses       2390     2390           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Contributor Author

tsalo commented Sep 20, 2024

I'm committing to just using +s, so I'm going to close this.

@tsalo tsalo closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants