MNT: Add flake8-logging-format (G) rules to ruff #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3242 +/- ##
=======================================
Coverage 72.06% 72.06%
=======================================
Files 57 57
Lines 4231 4231
Branches 455 455
=======================================
Hits 3049 3049
Misses 1067 1067
Partials 115 115 ☔ View full report in Codecov by Sentry. |
|
I'm not sure why we should care about this. |
|
The linter recommends that because that's what many programmers suggest: defer string interpolation to the log function so that string interpolation doesn't occur whenever the log function doesn't print at the current log level. So that would be a performance issue. The rationale is that the speed gain when deferring string interpolation with terse logging outwheighs the speed gain of f-strings with verbose logging. Other programmers don't agree. |
DimitriPapadopoulos
force-pushed
the
Q
branch
2 times, most recently
from
1e04537
to
26623f1
Compare
DimitriPapadopoulos
force-pushed
the
Q
branch
3 times, most recently
from
a7cdac8
to
7af53d2
Compare
DimitriPapadopoulos
force-pushed
the
Q
branch
from
919b764
to
2e8298d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Documentation that should be reviewed