Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: Fix ITK warp conversion to nitransforms format #3300

Merged
merged 6 commits into from
Jun 5, 2024
Merged

RF: Fix ITK warp conversion to nitransforms format #3300

merged 6 commits into from
Jun 5, 2024

Commits on Jun 5, 2024

  1. FIX: Ensure shape matches template 

    The reverse of the TransformFixedParameters should match the template dimensions.

This fell through the cracks because the templates tested (MNI152 variants) all have the same
X and Z dimensions. Only when testing on a template with distinct values for shape did this become evident.

Additionally, this removes any `FIXED_PARAMS` checks, as that is template specific and more useful for debugging the
initial implementation.
    @mgxd @effigies
    mgxd authored and effigies committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    69c02be View commit details
    Browse the repository at this point in the history

  2. Update fmriprep/utils/transforms.py 

    Co-authored-by: Chris Markiewicz <[email protected]>
    @mgxd @effigies
    mgxd and effigies committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    83d4461 View commit details
    Browse the repository at this point in the history

  3. STY: ruff, use trailing comma to force reshape to expand

    @effigies
    effigies committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0293a18 View commit details
    Browse the repository at this point in the history

  4. RF: Use all fixed parameters to construct warp affine 

    Break the transformation steps down to be very explicit, with comments.
    @effigies
    effigies committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a3a952f View commit details
    Browse the repository at this point in the history

  5. MNT: Directly depend on transforms3d

    @effigies
    effigies committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    55bea47 View commit details
    Browse the repository at this point in the history

  6. Update fmriprep/utils/transforms.py

    @effigies
    effigies authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    758e5ac View commit details
    Browse the repository at this point in the history