Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build docker images in GHA, store cache inline and push to GHCR #3380

Merged
merged 8 commits into from
Oct 12, 2024

Conversation

effigies
Copy link
Member

This PR is a potential model for nipreps using GHA to build Docker images. The latest build (from a previous commit's cache) took 2 minutes, including checkout, build and push. If the cache needs rebuilding, it's <10 minutes. This is a vast improvement from Circle all on it's own.

I will make a separate PR to start triggering Circle builds from GHA after build. I would like to get to a model of:

graph LR;
  subgraph GitHub;
    test & build
  end
  subgraph Circle
    build --> ds005 & ds054 & ds210
  end
  subgraph gh2["GitHub"]
    test & ds005 & ds054 & ds210 --> deploy
  end
Loading

Where Circle runs anything where we want inspectable artifacts and nothing else. For SDCflows, it would be tests again, but with artifact saving turned on.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (52eee57) to head (79ee1b6).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3380   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files          57       57           
  Lines        4231     4231           
  Branches      456      456           
=======================================
  Hits         3049     3049           
  Misses       1067     1067           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 03f6cd7 into master Oct 12, 2024
20 checks passed
@effigies effigies deleted the gha-docker-build branch October 12, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant