[FIX] force_fmapless on top of self-correcting pepolar bold #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, it seems there was no test for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 32 32
Lines 2831 2831
Branches 381 284 -97
=======================================
Hits 2371 2371
Misses 390 390
Partials 70 70 ☔ View full report in Codecov by Sentry. |
bpinsard
force-pushed
the
fix/dup_bids-id_force-syn
branch
from
b48366a
to
dc6d2f7
Compare
|
Not sure how that will behave with multi-subject cases, seee #455 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When force_fmapless is used on top of self-correcting pepolar bold, the fmapless estimator will get it's name from B0FieldIdentifier, creating a duplicate.
For now I just created a test to replicate that behavior and triggering the error that this PR will try to fix.