Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing guide. #641

Merged
merged 11 commits into from
Mar 8, 2023
Merged

Contributing guide. #641

merged 11 commits into from
Mar 8, 2023

Conversation

TheChymera
Copy link
Contributor

@TheChymera TheChymera commented Feb 15, 2023

Closes: #636

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 81.36% // Head: 81.36% // No change to project coverage 👍

Coverage data is based on head (5bf16a3) compared to base (260f0bc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files          42       42           
  Lines        3837     3837           
=======================================
  Hits         3122     3122           
  Misses        715      715           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

as quickly discussed

  • avoid duplicating info, so just point to info.py I guess where all are described
  • note that it is .rst not .md
  • mentioned that pip install heudiconv[all] would install with all dependencies for testing etc, and for local development should be pip install -e .[all] but git-annex installation would also be required for DataLad. Refer to http://handbook.datalad.org/ installation section

@TheChymera TheChymera force-pushed the contributing branch 7 times, most recently from 2861de4 to 6b8ce3b Compare February 15, 2023 20:38
@TheChymera TheChymera changed the title Pull request for contributing guide. Contributing guide. Feb 15, 2023
README.rst Show resolved Hide resolved
@yarikoptic yarikoptic added the documentation Changes only affect the documentation label Feb 17, 2023
@yarikoptic yarikoptic added this to the 0.13.0 milestone Feb 21, 2023
@yarikoptic
Copy link
Member

coolio, thanks!

@yarikoptic yarikoptic merged commit 71f4dbe into nipy:master Mar 8, 2023
@TheChymera TheChymera deleted the contributing branch March 8, 2023 17:00
@github-actions
Copy link

🚀 PR was released in v0.12.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide CONTRIBUTING.md (or .rst)
2 participants