TYP: Add a version stub to allow mypy to run without building #1210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @Factral in #1208 (comment) I realized that we could probably make the contribution process a little nicer to people not wanting to
pip install -e
orhatch build --hooks-only
just to make the pre-commit hooks run cleanly.This adds a
_version.pyi
thatmypy
will respect without even checking whether_version.py
is present.The biggest potential risk is
setuptools-scm
changing the contents of_version.py
in the future, but that seems low and a thing we can deal with if it comes up.No need to backport unless we get contributors to a maintenance branch.
Verifying:
Reverting to
master
: