changes for globalLabels and globalAnnotations #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anushkamittal2001 <[email protected]>
pns-nirmata
reviewed
Jan 29, 2024
| podAnnotations: | ||
| {{- if .Values.globalAnnotations }} | ||
| {{- toYaml .Values.globalAnnotations | nindent 10 }} | ||
| {{- end}} |
There was a problem hiding this comment.
Can we confirm if the globalLabels and globalAnnotations are "added" to default labels and annotations in kyverno pods? Or it completely overwrites? If it overwrites, there might be other issues, so we better avoid that.
There was a problem hiding this comment.
Confirmed!
pns-nirmata
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a new PR as the last one wasnt working as expected.
https://nirmata.atlassian.net/browse/NDEV-18177
closed #227