pip: fix example lockfiles, add paths.lockFile default #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even with the new default, it's good to be explicit. And the examples will still refer to the main branch while running ci checks for this
quick & easy way to reduce ci run-time and overhead from platform-specific lock files in the repo while letting us catch errors on two OSes as well as architectures.
phaer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, lock files on main are currently wrong, as we need them per platform now. This PR fixes that & drops aarch64-linux and x86_64-darwin from CI targets for now. This makes locking easier, CI faster and we should still fetch issues specific to aarch64 or darwin.
And set a system-specific default for paths.lockFile for all pip users.