Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update wake and switch to nixpkgs 23.11 #427

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Conversation

selfuryon
Copy link
Collaborator

I did:

I also need to instantiate poetry2nix.mkPoetryApplication, but I can't. I hope it close #421

@selfuryon selfuryon self-assigned this Jan 8, 2024
@selfuryon
Copy link
Collaborator Author

@catwith1hat
Copy link
Contributor

catwith1hat commented Jan 8, 2024

@selfuryon I have a competing unfinished commit to update to nixpkgs-23.11. Here is what I found:

  • lighthouse doesn't build on 23.11 because Rust is too new. Lighthouse depends on an old version of libmdbx-rs in its slasher Cargo.tomb, and that old libmdbx-rs in turn points to an old bindgen library. The old bindgen dependency chokes on an LLVM dependency update like this. bindgen would need to be updated inside sipg's fork of libmdbx-rs. But I am not going to touch that to be frank. I "solved" this by introducing a nixpkgs_2305 input and just having lighthouse stay behind.
  • ssvnode: My fix is exactly like yours. Just my override is inside packages/default.nix.
  • I haven't fixed Nimbus yet in my commit.
    Just FYI.

@selfuryon
Copy link
Collaborator Author

@selfuryon I have a competing unfinished commit to update to nixpkgs-23.11. Here is what I found:

* lighthouse doesn't build on 23.11 because Rust is too new. Lighthouse depends on an old version of libmdbx-rs in its slasher Cargo.tomb, and that old libmdbx-rs in turn points to an old bindgen library. The old bindgen dependency chokes on an LLVM dependency update like [this](https://github.com/rust-lang/rust-bindgen/issues/2312). bindgen would need to be updated inside sipg's fork of libmdbx-rs. But I am not going to touch that to be frank. I "solved" this by introducing a nixpkgs_2305 input and just having lighthouse stay behind.

* ssvnode: My fix is exactly like yours. Just my override is inside packages/default.nix.

* I haven't fixed Nimbus yet in my commit.
  Just FYI.

For the first point seems related this one: sigp/lighthouse#4280. Maybe we can just disable slasher feature for now to mitigate that. I will try

@selfuryon
Copy link
Collaborator Author

Good, switch to slasher-lmdb (it's enabled by default) helps

@selfuryon selfuryon marked this pull request as ready for review January 8, 2024 21:38
@selfuryon
Copy link
Collaborator Author

The only problem that poetry2nix.mkPoetryApplication still is the derivation, idk how to fix that

@catwith1hat
Copy link
Contributor

The only problem that poetry2nix.mkPoetryApplication still is the derivation, idk how to fix that

My approach was to also add the poetry2nix overlay to pkgs

          pkgs = lib.extras.nix.mkNixpkgs {
            inherit system;
            inherit (inputs) nixpkgs;
+            overlays = [inputs.poetry2nix.overlays.default];
          };

This made my nix flake check pass.

@selfuryon
Copy link
Collaborator Author

The only problem that poetry2nix.mkPoetryApplication still is the derivation, idk how to fix that

My approach was to also add the poetry2nix overlay to pkgs

          pkgs = lib.extras.nix.mkNixpkgs {
            inherit system;
            inherit (inputs) nixpkgs;
+            overlays = [inputs.poetry2nix.overlays.default];
          };

This made my nix flake check pass.

Is nix flake show also works fine without --allow-import-from-derivation?

@catwith1hat
Copy link
Contributor

Is nix flake show also works fine without --allow-import-from-derivation?

No, but nix flake show doesn't work either on the current main branch.

@selfuryon
Copy link
Collaborator Author

Is nix flake show also works fine without --allow-import-from-derivation?

No, but nix flake show doesn't work either on the current main branch.

Yeah, but with flake-utils with the same style it works, I just wanted to fix that, but maybe it would be easy to fix a script for nix-update.

@brianmcgee @aldoborrero can you pls check this PR and approve it?

Copy link
Collaborator

@brianmcgee brianmcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@brianmcgee brianmcgee merged commit 8a1b13d into main Jan 25, 2024
61 checks passed
@brianmcgee brianmcgee deleted the chore/update-wake branch January 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with update flake packages action
3 participants