UKI Compatibility for systemd 255 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd 255 is stricter in what it considers UKIs. It demands .linux and .initrd sections. Rename our sections that contain the respective filenames to match these names.
nikstur
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames section names in our thin stub:
.kernelp->.linux.initrdp->.initrd.kernelh->.linuxh(for consistency)This allows
bootctl kernel-inspectto properly parse our UKIs. Before it would not recognize them as UKIs.We basically have to satisfy this function in systemd: https://github.com/systemd/systemd/blob/main/src/shared/pe-binary.c#L230
@nikstur Does this have backward compatibility issues?
Fixes #296. Relates to #295.