Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jar mode execution ci pipeline and status json add [not ready] #241

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Jar mode execution ci pipeline and status json add [not ready] #241

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2549fde
expected status json add
Apr 10, 2024
115b91d
ci pipeline steps add
Apr 10, 2024
9562d3f
pass parameter for compile program
Apr 10, 2024
c3b8e24
Merge remote-tracking branch 'upstream/main' into jar
Apr 11, 2024
40f8da5
json update
Apr 11, 2024
1d3c3d7
status chagne
Apr 11, 2024
0174e67
Merge remote-tracking branch 'upstream/main' into jar
Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,18 @@ jobs:
diff -uw src/main/resources/min_program_compile_status.json specimin-evaluation/ISSUES/compile_status.json
- name: Check preservation status
run: diff -uw src/main/resources/preservation_status.json specimin-evaluation/ISSUES/preservation_status.json

- name: Jar mode evaluation script execution
run: |
cd specimin-evaluation
echo "specimin path-> $SPECIMIN"
python main.py -j true
- name: Jar mode specimin execution status check
run: diff -uw src/main/resources/jar_mode_specimin_execution_status.json specimin-evaluation/ISSUES/target_status.json
- name: Jar mode targets compile status check
run: |
cd specimin-evaluation
sh check_jar_mode_compilation.sh
cd ..
diff -uw src/main/resources/jar_mode_min_program_compilation_status.json specimin-evaluation/ISSUES/jar_compile_status.json
- name: Jar mode preservation status check
run: diff -uw src/main/resources/jar_mode_preservation_status.json specimin-evaluation/ISSUES/preservation_status.json
2 changes: 2 additions & 0 deletions src/main/java/org/checkerframework/specimin/SpeciminRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ public static void main(String... args) throws IOException {
jarFiles = getJarFiles(jarDirectory);
}

jarFiles.stream().forEach(System.out::println);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be removed before merging.


performMinimization(
options.valueOf(rootOption),
options.valuesOf(targetFilesOption),
Expand Down
23 changes: 23 additions & 0 deletions src/main/resources/jar_mode_min_program_compilation_status.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"cf-1291": "FAIL",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these accurate? If so, that's very concerning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects where I could not write the script to pull dependencies, specimin was not run on them and results are showing as FAIL.
specimin was not executed on cf-1291 in jar mode. Thats why status is FAIL

"cf-6282": "FAIL",
"cf-6077": "FAIL",
"cf-6060": "FAIL",
"cf-6030": "FAIL",
"cf-6030b": "FAIL",
"cf-6019": "FAIL",
"cf-4614": "FAIL",
"cf-3850": "FAIL",
"cf-577": "FAIL",
"cf-3032": "FAIL",
"cf-3619": "FAIL",
"cf-3021": "FAIL",
"cf-3020": "FAIL",
"cf-3022": "FAIL",
"cf-691": "FAIL",
"Issue689": "FAIL",
"cf-6388": "FAIL",
"cf-3025": "FAIL",
"jdk-8319461": "FAIL",
"jdk-8288590": "FAIL"
}
23 changes: 23 additions & 0 deletions src/main/resources/jar_mode_preservation_status.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"cf-1291": "FAIL",
"cf-6282": "FAIL",
"cf-6077": "FAIL",
"cf-6060": "FAIL",
"cf-6030": "FAIL",
"cf-6030b": "FAIL",
"cf-6019": "FAIL",
"cf-4614": "FAIL",
"cf-3850": "FAIL",
"cf-577": "FAIL",
"cf-3032": "FAIL",
"cf-3619": "FAIL",
"cf-3021": "FAIL",
"cf-3020": "FAIL",
"cf-3022": "FAIL",
"cf-691": "FAIL",
"Issue689": "FAIL",
"cf-6388": "FAIL",
"cf-3025": "FAIL",
"jdk-8319461": "FAIL",
"jdk-8288590": "FAIL"
}
23 changes: 23 additions & 0 deletions src/main/resources/jar_mode_specimin_execution_status.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"cf-1291": "FAIL",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these all FAIL? Is it because specimin-evaluation#37 hasn't yet been merged, so you don't know? Or are they actually all failing in local testing (if so, that's a crisis).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Professor, I only configured jar mode for cf-6282, other project is not yet configured for jar mode.
in jar mode, specimin producing minimized program for cf-6282. However compilation is failing for the minimized program.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The printed table will show the reason of failure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious. Did you use the jar files when compiling these projects? In essence, whichever jar files given to Specimin should also be used when compiling the minimized programs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right Loi, I did not use the jars when compiling these minimized projects. I need to modify the gradle script to use the jars. Now configuring that.

"cf-6282": "PASS",
"cf-6077": "FAIL",
"cf-6060": "FAIL",
"cf-6030": "FAIL",
"cf-6030b": "FAIL",
"cf-6019": "FAIL",
"cf-4614": "FAIL",
"cf-3850": "FAIL",
"cf-577": "FAIL",
"cf-3032": "FAIL",
"cf-3619": "FAIL",
"cf-3021": "FAIL",
"cf-3020": "FAIL",
"cf-3022": "FAIL",
"cf-691": "FAIL",
"Issue689": "FAIL",
"cf-6388": "FAIL",
"cf-3025": "FAIL",
"jdk-8319461": "FAIL",
"jdk-8288590": "FAIL"
}
Loading