Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional interfaces should not include a method if it's not used #334

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

theron-wang
Copy link
Collaborator

This PR fixes an issue present with na-791a where, even though a functional interface's method is not used, it is still being included in the output, causing compilation errors. Since the @FunctionalInterface annotation is removed, we should treat all interfaces equally.

@theron-wang theron-wang marked this pull request as ready for review July 25, 2024 20:47
@theron-wang theron-wang requested a review from kelloggm July 25, 2024 20:48
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a test case for this change? If not, we should wait until the NullAway bugs are running in CI, so that you can use na-791a as the test case to demonstrate that this fix works.

@theron-wang
Copy link
Collaborator Author

Test added. Thanks!

@theron-wang theron-wang requested a review from kelloggm July 25, 2024 21:31
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test :)

@kelloggm kelloggm merged commit ac79474 into njit-jerse:main Jul 26, 2024
2 checks passed
@theron-wang theron-wang deleted the functional-interface branch August 1, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants