Fully qualify types in generic synthetic method return types #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelloggm
requested changes
Jul 29, 2024
|
I added another test case, as you suggested. For the expected output I put the incorrect one, but I changed the check compilation scripts to ignore the compilation error for this case. |
kelloggm
approved these changes
Jul 30, 2024
| * This test checks that Specimin includes the fully qualified class name in generics when | ||
| * generating a synthetic method. For example, if a return type is Bar<com.foo.Foo>, the actual | ||
| * synthetic return type should be com.qualified.Bar<com.foo.Foo>. At this moment, we should expect | ||
| * this test case to fail. |
There was a problem hiding this comment.
Rather than "we should expect this test to fail", I would phrase this as "this test encodes Specimin's current behavior, which doesn't produce compilable output. If you break this test, it might not be a bad thing."
| // TODO: handle already fully qualified generic type arguments. Right now JavaTypeCorrect | ||
| // only outputs the simple class name, so there is no way to get its fully qualified name | ||
| // here without ambiguity (i.e. org.example.Foo and com.example.Foo are different signatures) | ||
| // with the same simple class name |
There was a problem hiding this comment.
Add a reference to the test that demonstrates the "bad" behavior to this comment.
|
Thanks :) Just changed the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a synthetic method with a generic return type had a type parameter in the same package as the target method, it would not keep its fully qualified name in its synthetic definition, leading to compilation errors seen in na-791b.
For example,
ImmutableSet.copyOfreturned anImmutableSet<Feature>, but in its synthetic definition,copyOfreturnedcom.google.common.collect.ImmutableSet<Feature>instead ofcom.google.common.collect.ImmutableSet<com.github.benmanes.caffeine.cache.Feature>.