Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port typecheck_one_test.sh to batch and fix check_differences.bat #349

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Port typecheck_one_test.sh to batch and fix check_differences.bat #349

merged 11 commits into from
Aug 5, 2024

Conversation

theron-wang
Copy link
Collaborator

@theron-wang theron-wang commented Aug 5, 2024 •
edited
Loading

This ports over the changes made in #335 to Windows, and it should also finally fix false positives regarding check_differences.bat.

@theron-wang theron-wang requested a review from kelloggm August 5, 2024 18:08
kelloggm
kelloggm approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know batch files well enough to detect low-level technical mistakes, but at a high-level this looks good. Thanks!

@kelloggm kelloggm enabled auto-merge (squash) August 5, 2024 18:11
@kelloggm kelloggm merged commit 0c6ebd9 into njit-jerse:main Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelloggm kelloggm kelloggm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theron-wang @kelloggm