CI_for_Specimin #351
Merged
CI_for_Specimin #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script optimized
changed secret to variable
optimized script
Update specimin_evaluation_CI.yml
kelloggm
approved these changes
Aug 8, 2024
| @@ -0,0 +1,132 @@ | |||
| name: specimin_evaluation_CI | |||
There was a problem hiding this comment.
Can we change the name of this job to be more descriptive of what it actually does? Maybe something like "check_compilable_percentage"?
There is already another CI job called "specimin-evaluation", so I'm trying to avoid confusion.
|
Ive made the necessary changes
…On Thu, Aug 8, 2024 at 3:46 PM Martin Kellogg ***@***.***> wrote:
@ kelloggm approved this pull request. Other than the name, this looks
good to me. In .github/workflows/specimin_evaluation_CI. yml: > @@ -0,0
+1,132 @@ +name: specimin_evaluation_CI Can we change the name of this job
to be more descriptive
***@***.**** approved this pull request.
Other than the name, this looks good to me.
------------------------------
In .github/workflows/specimin_evaluation_CI.yml
<https://urldefense.com/v3/__https://github.com/njit-jerse/specimin/pull/351*discussion_r1710180972__;Iw!!DLa72PTfQgg!MTj7lGiR02khHN-486IIEbtqkFTxFF7n4OG5UzL3cwxdEzasOKgNlABUcQFQzZsXRLMgTqqH5iUUJRIsB0rxE7T1hw$>
:
> @@ -0,0 +1,132 @@
+name: specimin_evaluation_CI
Can we change the name of this job to be more descriptive of what it
actually does? Maybe something like "check_compilable_percentage"?
There is already another CI job called "specimin-evaluation", so I'm
trying to avoid confusion.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/njit-jerse/specimin/pull/351*pullrequestreview-2228722059__;Iw!!DLa72PTfQgg!MTj7lGiR02khHN-486IIEbtqkFTxFF7n4OG5UzL3cwxdEzasOKgNlABUcQFQzZsXRLMgTqqH5iUUJRIsB0o8KXfj-g$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BIZGHNCFFVBWLCANX2BF6WTZQPDH3AVCNFSM6AAAAABMHDPTU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRYG4ZDEMBVHE__;!!DLa72PTfQgg!MTj7lGiR02khHN-486IIEbtqkFTxFF7n4OG5UzL3cwxdEzasOKgNlABUcQFQzZsXRLMgTqqH5iUUJRIsB0qRSFK_Gg$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@NiharikaJamble the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CI evaluates accuracy of specimin for any push/pull events on main.
It will check file CI_Latest_run_percentage.txt for the latest accuracy percentage of specimin.
The CI will pass if the current accuracy( accuracy calculated for current change) matches the existing accuracy of main branch, if not the CI will result in failure.
In case the calculated accuracy doesn't match, and is higher than the value present in the file, it needs to be manually updated to the txt file.