Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle method references #352

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Handle method references #352

merged 11 commits into from
Aug 9, 2024

Conversation

theron-wang
Copy link
Collaborator

Method references should be solvable, but only if their parameter types match the type arguments in its corresponding functional interface (for example, Function<?, ?> doesn't match String foo(int x) but Function<Integer, ?> does). The test case (a bit of a large one) is in SyntheticMethodRefsTest. Thanks!

@theron-wang theron-wang requested a review from kelloggm August 8, 2024 21:40
kelloggm
kelloggm requested changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great work, thanks! I have a few comments and I'd like to review again after they're addressed, but I think it'll be easy to merge this.

src/main/java/org/checkerframework/specimin/JavaLangUtils.java Outdated Show resolved Hide resolved
src/main/java/org/checkerframework/specimin/JavaLangUtils.java Outdated Show resolved Hide resolved
src/main/java/org/checkerframework/specimin/UnsolvedMethod.java Outdated Show resolved Hide resolved
src/main/java/org/checkerframework/specimin/UnsolvedSymbolVisitor.java Outdated Show resolved Hide resolved
src/main/java/org/checkerframework/specimin/UnsolvedSymbolVisitor.java Outdated Show resolved Hide resolved
src/main/java/org/checkerframework/specimin/UnsolvedSymbolVisitor.java Outdated Show resolved Hide resolved
src/main/java/org/checkerframework/specimin/UnsolvedSymbolVisitor.java Outdated Show resolved Hide resolved
src/main/java/org/checkerframework/specimin/UnsolvedSymbolVisitor.java Outdated Show resolved Hide resolved
@theron-wang theron-wang requested a review from kelloggm August 9, 2024 15:42
kelloggm
kelloggm approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/org/checkerframework/specimin/JavaLangUtils.java Outdated Show resolved Hide resolved
@kelloggm kelloggm enabled auto-merge (squash) August 9, 2024 16:07
@kelloggm kelloggm merged commit 47fb15f into njit-jerse:main Aug 9, 2024
3 checks passed
@theron-wang theron-wang deleted the method-references branch August 13, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelloggm kelloggm kelloggm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theron-wang @kelloggm