Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ElementTypes in @Target #355

Merged
merged 13 commits into from
Aug 26, 2024

Conversation

theron-wang
Copy link
Collaborator

Removes unused ElementTypes in @Target annotations. The current approach is to only remove ElementTypes, not add them, so we don't accidentally make a non TYPE_USE annotation into a TYPE_USE annotation, for example.

I also addressed two small bugs I encountered:

  • When all the wildcard import are JDK imports, synthetic classes should be generated in the current package instead of the first wildcard import package
  • Don't throw an exception when an annotation is applied on a package declaration

Instead of creating a new test case for this, I just modified one of the existing ones (SyntheticAnnotationTargetTest), since it's purpose already seemed to fit this PR.

Thanks!

Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelloggm kelloggm enabled auto-merge (squash) August 26, 2024 14:58
@kelloggm
Copy link
Collaborator

@theron-wang can you resolve the merge conflict? It should be easy: you just need to decide whether the code in this PR or the code in #354 (which I just merged) should run first.

@kelloggm kelloggm merged commit 20a1a97 into njit-jerse:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants