-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused ElementType
s in @Target
#355
Merged
kelloggm
merged 13 commits into
njit-jerse:main
from
theron-wang:annotation-target-types
Aug 26, 2024
Merged
Remove unused ElementType
s in @Target
#355
kelloggm
merged 13 commits into
njit-jerse:main
from
theron-wang:annotation-target-types
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelloggm
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/main/java/org/checkerframework/specimin/AnnotationTargetRemoverVisitor.java
Outdated
Show resolved
Hide resolved
@theron-wang can you resolve the merge conflict? It should be easy: you just need to decide whether the code in this PR or the code in #354 (which I just merged) should run first. |
…ang/specimin; branch 'main' of https://github.com/njit-jerse/specimin into annotation-target-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused
ElementType
s in@Target
annotations. The current approach is to only removeElementType
s, not add them, so we don't accidentally make a nonTYPE_USE
annotation into aTYPE_USE
annotation, for example.I also addressed two small bugs I encountered:
Instead of creating a new test case for this, I just modified one of the existing ones (
SyntheticAnnotationTargetTest
), since it's purpose already seemed to fit this PR.Thanks!