-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci logging improvement #374
Ci logging improvement #374
Conversation
…output resultsto github
It looks like this is not working - the CI job is failing with:
I suspect that the capitalization + file extension is the problem (the file in this PR is called |
Otherwise, the output of this PR looks great - I love that CI now gives a list of failures and failed compilations. |
It looks like something is still wrong: the two accuracy numbers are pulled correctly (and show up in the script's logs in the "parse accuracy %" and "read latest run % from file" steps), but in the comparison one of them is missing. |
@M3CHR0M4NC3R it looks like CI is still failing only because the number actually does need to be updated. Please do that, and then we can merge this. |
@M3CHR0M4NC3R this PR should've been merged already. Can you resolve the conflict and then merge it? |
As requested, here are changed to CI so the individual cases can be viewed. I'd like a second set of eyes to verify that the file paths are correct in this as I don't have an environment to run the CI script outright like github does.