Creating synthetic classes for unsolved FieldAccessExpr #61
Conversation
|
Professor, This PR adds the codes and tests for unsolved Please take a look. Thank you. |
src/test/resources/unsolvednonstaticfield/expected/org/sampling/OrgSamplingBazCalType.java
Show resolved
Hide resolved
| // this check is not very comprehensive, since a class can be in lowercase, and a method or | ||
| // field can be in uppercase. But since this is without the jar paths, this is the best we can | ||
| // do. | ||
| return Character.isUpperCase(field.getScope().toString().charAt(0)); |
There was a problem hiding this comment.
I don't fully understand why being uppercase tells us whether the field is unsolved. Is there some other invariant here that I'm missing, such as that unsolved fields always are static and need to be accessed via a class name?
There was a problem hiding this comment.
Professor, I will rename it. We know the field is unsolved because in the visit method for FieldAccessExpr, we check to see if the field is solved first before coming to this check.
There was a problem hiding this comment.
Please neglect my earlier response. Before that line, we have a try-catch block to see if the field is solvable. The uppercase check is for the caller of this field. Since we don't have jar paths, we simply assume that if a symbol is capital, then that capital is a class name.
There was a problem hiding this comment.
I'm still not fully happy with this, but I'll let it go for now as tech debt given the need to move quickly
|
Professor, I have updated the codes based on your suggestions. Please take a look. Thank you. |
| // this check is not very comprehensive, since a class can be in lowercase, and a method or | ||
| // field can be in uppercase. But since this is without the jar paths, this is the best we can | ||
| // do. | ||
| return Character.isUpperCase(field.getScope().toString().charAt(0)); |
There was a problem hiding this comment.
I'm still not fully happy with this, but I'll let it go for now as tech debt given the need to move quickly
No description provided.