Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in Checker Framework issue #66

Merged
merged 14 commits into from
Dec 7, 2023

Conversation

LoiNguyenCS
Copy link
Collaborator

No description provided.

@LoiNguyenCS
Copy link
Collaborator Author

Professor, this is the PR to fix #63. Here is what I have done:

  1. Add codes to handle the "var" keyword.
  2. Fix the codes for solving unsolved union types.
  3. Add codes so that Specimin will not create a synthetic class for a file that already exists.
  4. Add codes to add the Exception instance in the catch clause to the symbol table.

I have created the corresponding test cases for all of them.

Please take a look. Thank you.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm December 5, 2023 06:42
@LoiNguyenCS
Copy link
Collaborator Author

I've just updated the codes a bit to throw an exception when there is a wildcard import.

@LoiNguyenCS
Copy link
Collaborator Author

LoiNguyenCS commented Dec 7, 2023

Professor, I have updated the codes. I have also add two more modifications:

  1. A separate method to remove the return type in the declaration of a method, since return type can contain space.
  2. In PrunerVisitor, remove every unsolved symbol, since those symbols are not used by target methods.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm December 7, 2023 16:26
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the one minor comment. I don't need to review again.

@LoiNguyenCS LoiNguyenCS merged commit eb1b1bc into njit-jerse:main Dec 7, 2023
@LoiNguyenCS LoiNguyenCS deleted the fix-cf-issue branch December 7, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants