Implement equality checks for UnsolvedMethod based on the JLS rules #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LoiNguyenCS please make sure that when you merge this PR, #87 does not get automatically closed by GitHub (that has happened twice already with PRs related to #87, and I have had to go back and correct it). |
kelloggm
pushed a commit
that referenced
this pull request
Jul 23, 2024
…rvation (#327) This PR addresses an issue I discovered while running Specimin on [NullAway issue #102](uber/NullAway#102), where methods in an abstract class present in the parent interface of the implemented interface were not preserved. For example: Expected: ```java package com.example; import java.util.Iterator; public class Foo<E> { public Iterator<E> iterator() { return new AbstractLinkedIterator() { @OverRide E computeNext() { throw new Error(); } }; } public abstract class AbstractLinkedIterator implements Iterator1<E> { abstract E computeNext(); @OverRide public E next() { throw new Error(); } @OverRide public boolean hasNext() { throw new Error(); } } public interface Iterator1<E> extends Iterator<E> { } } ``` Actual: ```java package com.example; import java.util.Iterator; public class Foo<E> { public Iterator<E> iterator() { return new AbstractLinkedIterator() { @OverRide E computeNext() { throw new Error(); } }; } public abstract class AbstractLinkedIterator implements Iterator1<E> { abstract E computeNext(); } public interface Iterator1<E> extends Iterator<E> { } } ``` The current behavior is to only look for method declarations in the direct parent interface `Iterator1`, but those methods are not present there. This causes them to be removed and thus compile errors ensue. However, I modified `MustImplementMethodsVisitor` to explore all interface ancestors, so the `next()` and `hasNext()` methods are still preserved. The test case can be found in `InterfaceChainTest`. I also included a small tweak to annotation preservation in this PR; previously, we preserved JDK annotations by seeing if it started with `java.lang`, but I changed it to use `JavaLangUtils.inJdkPackage()` instead after discovering a conflict when looking at [NullAway issue #97](uber/NullAway#97). Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves one infinite loop that #87 triggers, but not all of them. The new test in this PR causes an infinite loop on
main.