Only log client connect failed when no handler is added

Signed-off-by: Yilun <[email protected]>
nknorg · Apr 16, 2022 · f6fa9cd · f6fa9cd
1 parent b67db9b
commit f6fa9cd
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 7 deletions.
diff --git a/dist/nkn.js b/dist/nkn.js
@@ -183,7 +183,6 @@ class Client {
 
   _connectFailed() {
     if (!this.isFailed) {
-      console.log('Client connect failed');
       this.isFailed = true;
 
       if (this.eventListeners.connectFailed.length > 0) {
@@ -194,6 +193,8 @@ class Client {
             console.log('Connect failed handler error:', e);
           }
         });
+      } else {
+        console.log('Client connect failed');
       }
     }
   }
@@ -10439,7 +10440,6 @@ class MultiClient {
     }));
 
     _promise.default.all(connectFailedPromises).then(() => {
-      console.log('All clients connect failed');
       this.isFailed = true;
 
       if (this.eventListeners.connectFailed.length > 0) {
@@ -10450,6 +10450,8 @@ class MultiClient {
             console.log('Connect failed handler error:', e);
           }
         });
+      } else {
+        console.log('All clients connect failed');
       }
     });
   }

diff --git a/dist/nkn.min.js b/dist/nkn.min.js
diff --git a/lib/client/client.js b/lib/client/client.js
@@ -182,7 +182,6 @@ class Client {
 
   _connectFailed() {
     if (!this.isFailed) {
-      console.log('Client connect failed');
       this.isFailed = true;
 
       if (this.eventListeners.connectFailed.length > 0) {
@@ -193,6 +192,8 @@ class Client {
             console.log('Connect failed handler error:', e);
           }
         });
+      } else {
+        console.log('Client connect failed');
       }
     }
   }

diff --git a/lib/multiclient/multiclient.js b/lib/multiclient/multiclient.js
@@ -271,7 +271,6 @@ class MultiClient {
     }));
 
     _promise.default.all(connectFailedPromises).then(() => {
-      console.log('All clients connect failed');
       this.isFailed = true;
 
       if (this.eventListeners.connectFailed.length > 0) {
@@ -282,6 +281,8 @@ class MultiClient {
             console.log('Connect failed handler error:', e);
           }
         });
+      } else {
+        console.log('All clients connect failed');
       }
     });
   }

diff --git a/src/client/client.js b/src/client/client.js
@@ -165,7 +165,6 @@ export default class Client {
 
   _connectFailed() {
     if (!this.isFailed) {
-      console.log('Client connect failed');
       this.isFailed = true;
       if (this.eventListeners.connectFailed.length > 0) {
         this.eventListeners.connectFailed.forEach(async f => {
@@ -175,6 +174,8 @@ export default class Client {
             console.log('Connect failed handler error:', e);
           }
         });
+      } else {
+        console.log('Client connect failed');
       }
     }
   }

diff --git a/src/multiclient/multiclient.js b/src/multiclient/multiclient.js
@@ -243,7 +243,6 @@ export default class MultiClient {
       this.clients[clientID].onConnectFailed(resolve);
     }));
     Promise.all(connectFailedPromises).then(() => {
-      console.log('All clients connect failed');
       this.isFailed = true;
       if (this.eventListeners.connectFailed.length > 0) {
         this.eventListeners.connectFailed.forEach(async f => {
@@ -253,6 +252,8 @@ export default class MultiClient {
             console.log('Connect failed handler error:', e);
           }
         });
+      } else {
+        console.log('All clients connect failed');
       }
     });
   }