Fix bug that will return closed successor

Signed-off-by: Yilun <[email protected]>
nknorg · Sep 10, 2018 · 2bde0ee · 2bde0ee
1 parent 2f5777c
commit 2bde0ee
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/net/chord/vnode.go b/net/chord/vnode.go
@@ -335,10 +335,11 @@ func (vn *localVnode) FindSuccessors(n int, key []byte) ([]*Vnode, error) {
 
 		// Try that node, break on success
 		res, err := vn.ring.transport.FindSuccessors(closest, n, key)
-		if err != nil {
+		if err == nil {
+			return res, nil
+		} else {
 			nlog.Infof("[WARNING] Failed to contact %s. Got %s", closest.String(), err)
 		}
-		return res, nil
 	}
 
 	// Determine how many successors we know of