Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text overflow of Code Block #402

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: text overflow of Code Block #402

merged 1 commit into from
Dec 18, 2024

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented Dec 18, 2024 •
edited
Loading

TODO:

  • discuss approach
  • unit test
  • argstable for Storybook

@Robbert Robbert requested a review from matijs December 18, 2024 08:39
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:51am
candidate-storybook-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:51am
evil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:51am

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (385fc70) to head (d2d520f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #402   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          329       346   +17     
  Branches        26        25    -1     
=========================================
+ Hits           329       346   +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbert Robbert marked this pull request as ready for review December 18, 2024 12:40
@Robbert @matijs
feat: improve Code Block
d2d520f 
- add `nowrap` and `overflow` modifiers to `nl-code-block` CSS
- add `overflow` property to `CodeBlock` in React
- update Code Block stories for overflow
- update Code Block tests
- add changeset
@matijs matijs enabled auto-merge (rebase) December 18, 2024 12:41
@matijs matijs self-requested a review December 18, 2024 12:41
@matijs matijs merged commit 5557084 into main Dec 18, 2024
8 of 11 checks passed
@matijs matijs deleted the fix/code-block branch December 18, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matijs matijs matijs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robbert @codecov-commenter @matijs