fix: Verplaats het aria-label op de link naar de SVG en voeg de ontbrekende aria-current toe #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best practive is to start the accessible name of a link with the visual text. The dot in het text is redundant, better use a comma for a short pauze. The aria-current was missing on the link for the story “Link rondom image, current page”.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 391 391
Branches 30 32 +2
=========================================
Hits 391 391 ☔ View full report in Codecov by Sentry. |
rianrietveld
changed the title
matijs
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
We moeten er op een later tijdstip en zeker in een aparte PR nog voor kiezen om het SVG image ergens anders onder te brengen:
- in het storybook shared package als het ook in andere storybooks gebruikt moet kunnen worden
- in
packages/storybook-test/srczodat we de Link stories er verder niet mee lastig vallen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practice is om de toegankelijke naam van een link te beginnen met de visuele tekst. De dot in de tekst is overbodig, gebruik voor een korte pauze beter een komma.
De
aria-currentontbrak op de link voor het verhaal “Link rondom image, current page” en is nu toegevoegd.De toegankelijke naam staat op de SVG.
Vergelijkbaar met het geval van een img met een alt attribuut.
ZIe voor uitleg: https://www.htmhell.dev/adventcalendar/2024/1/
Preview: https://candidate-storybook-test-git-fix-logo-i-ae48c3-nl-design-system.vercel.app/?path=/docs/componenten-link--documentatie
Gerelateerd issue: #210