Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 4 new components: root/body/page-layout/page-body #2656

Merged
merged 8 commits into from
Feb 9, 2025

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented Nov 28, 2024

The components already existed as React components, but now:

  • they have Utrecht styling
  • have stories in Storybooks for Web Components / React / CSS
  • have web component implementations
  • are available as part of the component-library-css

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:10pm

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (822fc9f) to head (145264a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2656   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         188      188           
  Lines        1644     1644           
  Branches      350      358    +8     
=======================================
  Hits         1483     1483           
+ Misses        157      155    -2     
- Partials        4        6    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbert Robbert force-pushed the feat/page-layout-web-component branch from a11eac6 to d19a614 Compare February 9, 2025 15:29
@Robbert Robbert force-pushed the feat/page-layout-web-component branch from d19a614 to 145264a Compare February 9, 2025 20:58
@Robbert Robbert requested a review from Yolijn February 9, 2025 20:59
@Robbert Robbert changed the title feat: add 4 new web components: root/body/page-layout/page-body feat: add 4 new components: root/body/page-layout/page-body Feb 9, 2025
Copy link

sonarqubecloud bot commented Feb 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
22.4% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Robbert Robbert enabled auto-merge (rebase) February 9, 2025 21:08
@Robbert Robbert merged commit 1e03612 into main Feb 9, 2025
15 of 17 checks passed
@Robbert Robbert deleted the feat/page-layout-web-component branch February 9, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants