Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Read files content lazily [joelanford edits] #16

Closed
wants to merge 9 commits into from
Closed

✨ Read files content lazily [joelanford edits] #16

wants to merge 9 commits into from

Commits on Jul 27, 2023

  1. Add benchmarks

    @nlepage
    nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b8bf38c View commit details
    Browse the repository at this point in the history

  2. ✨ Read files content lazily

    @nlepage
    nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    97682bb View commit details
    Browse the repository at this point in the history

  3. keep track of offset of each entry's data 

    use the offset to avoid iterating tar file when opening each file.

Signed-off-by: Joe Lanford <[email protected]>
    @joelanford @nlepage
    joelanford authored and nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    592f9c1 View commit details
    Browse the repository at this point in the history

  4. if the reader is not a readerAt, read it into a buffer 

    after we've read the non-readerAt reader into a buffer, we now have a
readerAt either way, which simplifies code and no longer requires
separate buffers per file entry.

Signed-off-by: Joe Lanford <[email protected]>
    @joelanford @nlepage
    joelanford authored and nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    10a4e22 View commit details
    Browse the repository at this point in the history

  5. Improve ReadFile test

    @nlepage
    nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    81414a6 View commit details
    Browse the repository at this point in the history

  6. Fix reading sparse files 

    Reading file content straight from the underlying reader was too straightforward.

Instead read from a new tar.Reader with an underlying reader pointing straight to the tar entry we want to read.
    @nlepage
    nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    fc163f7 View commit details
    Browse the repository at this point in the history

  7. Use composition in countingReader

    @nlepage
    nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    653ea9a View commit details
    Browse the repository at this point in the history

  8. Forward Seek method on ReadCounter when possible 

    Should improve initial read of the tar file.
    @nlepage
    nlepage committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    4470b8a View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. make io.Seeker implementation optional 

    Signed-off-by: Joe Lanford <[email protected]>
    @joelanford
    joelanford committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    31be8d2 View commit details
    Browse the repository at this point in the history