Return the poped.db (and update for shrinkage)

nlmixr2 · Oct 17, 2024 · fb3a8cc · fb3a8cc
1 parent 28d30c0
commit fb3a8cc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/R/poped.R b/R/poped.R
@@ -336,15 +336,15 @@ rxUiGet.popedFfFun <- function(x, ...) {
     # be in the right order
     if (.lu <=  .(.poped$maxn)) {
       # only check for time reset if it is specified in the model
+      poped.db <- .popedRxRunSetup(poped.db)
       .p <- babelmixr2::popedMultipleEndpointParam(p, .u, model_switch,
                                                    .(.poped$maxn),
                                                    poped.db$babelmixr2$optTime)
-      .popedRxRunSetup(poped.db)
       .ret <- .popedSolveIdME(.p, .u, .xt, model_switch, .(length(.predDf$cond)),
                               .id-1, .totn)
     } else if (.lu > .(.poped$maxn)) {
       .p <- p[-1]
-      .popedRxRunFullSetupMe(poped.db, .xt, model_switch)
+      poped.db <- .popedRxRunFullSetupMe(poped.db, .xt, model_switch)
       .ret <- .popedSolveIdME2(.p, .u, .xt, model_switch, .(length(.predDf$cond)),
                                .id-1, .totn)
     }
@@ -423,7 +423,7 @@ attr(rxUiGet.popedFfFun, "desc") <- "PopED parameter model (ff_fun)"
     .poped$setup <- 1L
     .poped$fullXt <- NULL
   }
-  invisible()
+  invisible(popedDb)
 }
 #' Setup a full solve for a multiple-endpoint model
 #'
@@ -493,6 +493,7 @@ attr(rxUiGet.popedFfFun, "desc") <- "PopED parameter model (ff_fun)"
     .poped$curNumber <- popedDb$babelmixr2$modelNumber
     .poped$setup <- 2L
   }
+  popedDb
 }
 #' Setup for a full solve with a single endpoint model
 #'
@@ -559,6 +560,7 @@ attr(rxUiGet.popedFfFun, "desc") <- "PopED parameter model (ff_fun)"
     .poped$curNumber <- popedDb$babelmixr2$modelNumber
     .poped$setup <- 2L
   }
+  popedDb
 }
 
 #' This gets the epsi associated with the nlmixr2/rxode2 model specification

diff --git a/tests/testthat/test-poped.R b/tests/testthat/test-poped.R
@@ -324,14 +324,11 @@ if (requireNamespace("PopED", quietly=TRUE)) {
         tKa <- 0.25
         tCl <- 3.75
         tF <- fix(0.9)
-
         eta.v ~ 0.09
         eta.ka ~ 0.09
         eta.cl ~0.25^2
-
         prop.sd <- fix(sqrt(0.04))
         add.sd <- fix(sqrt(5e-6))
-
       })
       model({
         V<-tV*exp(eta.v)
@@ -343,7 +340,6 @@ if (requireNamespace("PopED", quietly=TRUE)) {
           (exp(-CL/V * (time - (N - 1) * TAU)) *
              (1 - exp(-N * CL/V * TAU))/(1 - exp(-CL/V * TAU)) -
              exp(-KA * (time - (N - 1) * TAU)) * (1 - exp(-N * KA * TAU))/(1 - exp(-KA * TAU)))
-
         y ~ prop(prop.sd) + add(add.sd)
       })
     }