Skip to content

Commit

Permalink
Update cran-comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mattfidler committed Dec 11, 2023
1 parent c108688 commit 49d69dd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
10 changes: 3 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
Fixed and tested memory checks like valgrind/csan etc. Also fixed LTO

## R CMD check results

0 errors | 0 warnings | 1 note

* This is a new release.
# Fixes for new release
- Fixed and tested security issues as flagged by CRAN.
- Made to work with CRAN version of `rxode2`
3 changes: 1 addition & 2 deletions src/abbrec.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ SEXP _nonmem2rx_setRecord(SEXP rec) {
return R_NilValue;
}


extern D_ParserTables nonmem2rxAbbrevRec;

char* gBuf;
Expand Down Expand Up @@ -212,7 +211,7 @@ int abbrecProcessDataParItem(const char* name, D_ParseNode *pn) {
if (!strcmp("replace_data", name)) {
D_ParseNode *xpn = d_get_child(pn, 0);
abbrecVarType = (char*)rc_dup_str(xpn->start_loc.s, xpn->end);
xpn = d_get_child(pn, 5);
xpn = d_get_child(pn, 5);
char *tmp = (char*)rc_dup_str(xpn->start_loc.s, xpn->end);
if (strcmp(abbrecVarType, tmp)) {
sClear(&sbTransErr);
Expand Down

0 comments on commit 49d69dd

Please sign in to comment.