Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and pkgdown fix #799

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Documentation and pkgdown fix #799

merged 5 commits into from
Oct 25, 2024

Conversation

billdenney
Copy link
Contributor

No functional changes

@billdenney
Copy link
Contributor Author

@mattfidler, I got things farther, but there seems to be something like a crash here. Can you diagnose that?

@mattfidler
Copy link
Member

It isn't a crash per-se it a difference in how evaluate behaves with the new version. I simply need to completely rewrite et() or take out the examples. It consistently hangs when generating these examples though they run interactively just fine.

@mattfidler
Copy link
Member

They also run just fine in Rmarkdown alone...

@mattfidler
Copy link
Member

I think this is an error in evaluation in either pkgdown or evaluate. Ignoring these works just fine.

@mattfidler mattfidler merged commit 591f0f0 into main Oct 25, 2024
6 of 7 checks passed
@billdenney billdenney deleted the doc-pkgdown-fix branch January 1, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants