Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for alpine linux #8

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Update for alpine linux #8

merged 6 commits into from
Nov 21, 2024

Conversation

mattfidler
Copy link
Member

Match windows reqirements

@mattfidler
Copy link
Member Author

mattfidler commented Nov 21, 2024

Hi, @bastistician

Let me know if this works for you. If so, I will adapt it for all other work-arounds.

I can submit this to CRAN now, since it has been over 30 days since my last submit with rxode2ll. For the other packages I may have to wait until Dec or next year.

@bastistician
Copy link

Thanks for working on this portability issue.
The change in this PR won't work as intended. Makevars.win isn't used on linux.

--------[begin src/Makevars]--------
cat: can't open 'src/Makevars': No such file or directory
--------[end src/Makevars]--------

@mattfidler
Copy link
Member Author

This should work for alpine linux.

@mattfidler
Copy link
Member Author

mattfidler commented Nov 21, 2024

@bastistician
Copy link

Ah I see, so -isystem was intended as a workaround for PopOS? It seems -I will now be used everywhere but on that OS. Note that the PRETTY_NAME or NAME info from /etc/os-release is already stored in utils::osVersion, so you could just check that string.

Anyway, I can confirm that the current version of this PR installs and checks fine on Alpine Linux. Thanks!

@mattfidler
Copy link
Member Author

Ah I see, so -isystem was intended as a workaround for PopOS?

No, actually I meant this for all systems that support -isystem; but since I develop on PopOS, I want to use it there at the very least. The -isystem flag suppresses all non rxode2ll system messages that I need to take care of instead of showing the many, many stan math/eigen warnings that make it difficult to figure out what needs to be fixed on my end (with -I).

It also makes the compilation experience a bit easier to digest. But it truly isn't needed otherwise.

So out an abudence of caution, I have disabled it on every platform except the one I develop on 😄

@mattfidler mattfidler closed this Nov 21, 2024
@mattfidler mattfidler reopened this Nov 21, 2024
@mattfidler
Copy link
Member Author

Thanks for the suggestion @bastistician, integrated it as suggested.

@mattfidler mattfidler merged commit 0924eed into main Nov 21, 2024
6 of 7 checks passed
@mattfidler mattfidler deleted the 7-alpine-linux-work-around branch November 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants