Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4271: Use OS independent utf8 string representation of std_fs::path at to_j… #4502

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

#4271: Use OS independent utf8 string representation of std_fs::path at to_j… #4502

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c5083d
Use OS independent utf8 string representation of std_fs::path at to_j…
zel1b08a Nov 19, 2024
efac3b3
Add char8_t feature guard.
zel1b08a Dec 7, 2024
e41bfbc
Remove empty line.
zel1b08a Dec 7, 2024
c859d64
Merge branch 'nlohmann:develop' into patch-1
zel1b08a Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/nlohmann/detail/conversions/to_json.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ inline void to_json(BasicJsonType& j, const T& t)
template<typename BasicJsonType>
inline void to_json(BasicJsonType& j, const std_fs::path& p)
{
j = p.string();
j = p.u8string();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that from C++20, u8string will return std::u8string instead of std::string - I am not sure if this assignment works in this case.

Copy link
Author

@zel1b08a zel1b08a Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the copy with reinterpret_cast to char* there only..)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a remark on cppreference.com

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the u8string to string conversion here in that issue

}
#endif

Expand Down
Loading