-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added first draft of new FSC-specific citations #107
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
…dated test to work with new citation style.
"Please cite this publication as: \n", | ||
"\n", | ||
author_list, ". ", title, ".", year, | ||
". Prepared by [COMMITTEE]. [XX] p." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this can be automated...
"\n", | ||
author_list, ". ", year, ". ", | ||
title, ". NOAA Tech. Memo. [TECH MEMO NUMBER]", | ||
", ", "[XX] p." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
title, ". ", off_title, ", ", | ||
loc_city, ", ", loc_state, ". " | ||
"SEDAR. ", year, ". ", title, ". ", | ||
"SEDAR, North Charleston SC. [XX] pp. ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - I haven't test this. I am wondering if we can add code that would automate the number of pages (I feel like this should be possible)
From a little googling, I'm not finding any quick fixes. I think it might be tricky. The workflow for calculating the page length might be: render to pdf with latex, then put the number back into the R script. I'm not sure R could accurately calculate page length before rendering. What if we added it as an issue for the future? |
@sbreitbart-NOAA That works! Maybe just something to think about as an added feature, but if we can't do it, we can't do it 🤷 |
You can use a call to latex within the template that puts in the number of page numbers on the second time that it is built.
|
Awesome, thanks Kelli!! We put this into a new issue #108 and will revisit after the first release. |
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?