Add unit tests #40
Merged
Add unit tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a figure or table so that if one function fails, the rest can still produce rdas
Failsafe for exp_all_figs_tables
- Fix bug preventing key quantities from being substituted in alt text/captions csv. - Suppress warnings for write_captions
… and rda_dir = getwd()
…g deleted upon end of test
Schiano-NOAA
reviewed
Jan 6, 2025
Schiano-NOAA
reviewed
Jan 6, 2025
There was a problem hiding this comment.
I think this might cause an issue with download times of the package depending on how large this file is. We will need to chat as a group about running a simple SS3 model we can use for a sample data set - for use in both asar and satf
There was a problem hiding this comment.
I filtered the dataset to include data collected in 2020 or later, so it's <5 MB. Is that too large?
There was a problem hiding this comment.
I think under 10 is fine for a package but we'd have to look up the cran standard. I think though have a simple example would be nice because we would be familiar with it and know what to expect
With that said, let's leave this one in for now and revisit
Schiano-NOAA
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making unit tests for
satf