Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about retention required for part = 2 #197

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

iantaylor-NOAA
Copy link
Contributor

This change adds a note "Note: if retention is not defined in the selectivity section, observations with Partition = 2 will be changed to Partition = 0" to the two descriptions of partition (in the "Mean Body Weight or Length" and "Length Composition Data" sections) and also aligns the descriptions with each other a little bit.

Resolves #153.

@iantaylor-NOAA iantaylor-NOAA added documentation Improvements or additions to documentation 3.30.22 release labels Oct 13, 2023
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me that it would be good to keep the term "whole" in the definition of combined. Maybe: combined (whole, e.g. discard+retained).

Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@e-perl-NOAA e-perl-NOAA merged commit 678fc85 into main Oct 25, 2023
4 checks passed
@e-perl-NOAA e-perl-NOAA deleted the partition_note_153 branch January 17, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.30.22 release documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes need for SS3 PR 440
3 participants